Paul Kocialkowski has posted comments on this change. ( https://review.coreboot.org/23261 )
Change subject: ENE EDI - print debug info like others while probing for ENE chips ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/23261/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23261/5//COMMIT_MSG@12 PS5, Line 12: Probing for ENE KB9012 (EDI), 128 kB: edi_chip_probe: rc1 0, rc2 0; hwversion 0xc3, ediid 0x04 In the end, it should look like: Probing for ENE KB9012 (EDI), 128 kB: edi_chip_probe: hwversion 0xc3, ediid 0x04 Found ENE flash chip "KB9012 (EDI)" (128 kB, SPI) on ch341a_spi.
So this should be updated accordingly.
https://review.coreboot.org/#/c/23261/5/edi.c File edi.c:
https://review.coreboot.org/#/c/23261/5/edi.c@164 PS5, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) { After a closer look, it looks like this is not consistent with the way it's done for spi25 chips.
I suggest adding the the following line here (note that it has to be msg_cdbg, not msg_cdbg2): msg_cdbg("%s: hwversion 0x%02x, ediid 0x%02x\n", __func__, hwversion, ediid);
And dropping the changes below.
More specifically, we don't want to highlight the mismatch, that will necessarily happen when adding more ENE chips.