Change in flashrom[staging]: Convert flashrom to git

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 )

Change subject: Convert flashrom to git
......................................................................

Patch Set 1:

(9 comments)

Haven't looked at the commit message and getrevision.sh yet.

https://review.coreboot.org/#/c/19206/1/Makefile
File Makefile:

PS1, Line 1369: 	@sed	-e  's/^VERSION :=.*/VERSION := $(VERSION)/' \
              : 		-e 's/^MAN_DATE :=.*/MAN_DATE := $(MAN_DATE)/' \
              : 		-e 's#./util/getrevision.sh -c#false#' \
              : 		Makefile >"$(EXPORTDIR)/flashrom-$(RELEASENAME)/Makefile"
I'd rather not review a self-modifying Makefile...

How about a Makefile.version that gets included if it exists? Plus
providing weak overrides for these variables.

Line 1374: #	sed is required to filter out file names having the attribute set.
Hmmm, fancy. One nit and one problem here:

PS1, Line 1377: x;n;n;s/^set$$//;t;x;p
I think 'x;n;n;/^set$$/{b};x;p' would be more clear.

PS1, Line 1378: for f; 
This will ignore $0 which is the first argument after the command for
`sh -c`...

Line 1381: 		done'
...could be simply fixed by adding a dummy after the command like

done' dummy_arg0

https://review.coreboot.org/#/c/19206/1/util/git-hooks/install.sh
File util/git-hooks/install.sh:

PS1, Line 17: ../../
This assumption looks rather odd given the `git rev-parse` above.

I think this is:

"$(git rev-parse --prefix $(git rev-parse --git-path hooks/) --show-cdup)${src}wrapper.sh"

https://review.coreboot.org/#/c/19206/1/util/git-hooks/pre-push
File util/git-hooks/pre-push:

PS1, Line 1: #!/bin/sh
But it looks like a bash script to me.

PS1, Line 53: No Signoff or Ack 
This reads abiguous. I think it wants to say "Either Signoff or Ack not found ...".

PS1, Line 57: 		# Make _really_ sure we do not rewrite precious history
            : 		for lbranch in "${precious_branches[@]}"; do
            : 			if [ "$remote_ref" = "refs/heads/$lbranch" ]; then
            : 				nonreachable=$(git rev-list $remote_sha ^$local_sha)
            : 				if [ -n "$nonreachable" ]; then
            : 					echo "Only fast-forward pushes are allowed on $lbranch." >&2
            : 					echo "$nonreachable is not included in $remote_sha while pusing to $remote_ref" >&2
            : 					exit 1
            : 				fi
            : 			fi
            : 		done
Isn't this configurable in the upstream repo?