Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55265 )
Change subject: dummyflasher.c: Drop useless macros
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/55265/comment/4b272f94_116929ef
PS2, Line 28: #include <sys/stat.h>
I guess these two should go up to the other standard headers?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f
Gerrit-Change-Number: 55265
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 08 Jun 2021 18:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment