Attention is currently required from: Brian Norris, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81545?usp=email )
Change subject: udelay: only use OS time for delays, except on DOS ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/81545/comment/77d2ad59_24d5233c : PS4, Line 25: For the patch like this, it would be useful to know what was tested, if you could add testing info here, at least from yourself, it would be great! (whenever you will have such info, I understand it might be ready a bit later).
Patchset:
PS4: Thank you so much for the patch!
File meson.build:
https://review.coreboot.org/c/flashrom/+/81545/comment/db72f8ed_b0a68bf9 : PS4, Line 121: DHAVE_NANOSLEEP=1 I didn't find this to be ever defined in Makefile, is it right? I thought there would be something in Makefile too?
File udelay.c:
https://review.coreboot.org/c/flashrom/+/81545/comment/fc39ae6f_9e6f8054 : PS4, Line 6: * I think this counts as a significant change, maybe you want to add your copyright here?
-
Anastasia Klimchuk (Code Review)