Attention is currently required from: Alexander Goncharov, Miklós Márton.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email )
Change subject: ni845x_spi: pass global state through func params ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS2:
Thanks to the now available build instructions for NI-845x on Windows. […]
Great, thanks for compiling! That's very good news.
About testing on HW: Miklos hopefully will be able to test on HW in around a month, but not earlier. Meanwhile we can confirm that it builds with/without NI-845x , and if yes then the chain can be merged! I think you already confirmed it builds right?
I am not sure about CB:72159 , is it still needed? If not, you can abandon it.
Patchset:
PS6: Joursoir, could you please rebase because the other chain was merged and now this is in "merge conflict" state?
-
Anastasia Klimchuk (Code Review)