[L] Change in flashrom[master]: flashrom.c: Add functions for new erase selction algorithm
Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Anastasia Klimchuk. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 ) Change subject: flashrom.c: Add functions for new erase selction algorithm ...................................................................... Patch Set 87: (7 comments) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/65844/comment/902bdbb0_628e4869 PS86, Line 114: s
`const` Done
https://review.coreboot.org/c/flashrom/+/65844/comment/0d758814_8b0f2b3a PS86, Line 130: size_t num;
delete Done
https://review.coreboot.org/c/flashrom/+/65844/comment/83ce6786_3bd78fad PS86, Line 133: (
`size_t num = 0;` Done
https://review.coreboot.org/c/flashrom/+/65844/comment/04c23b22_172acdcf PS86, Line 165: const unsigned int
`const size_t`? Done
https://review.coreboot.org/c/flashrom/+/65844/comment/b7b50688_e86a0048 PS86, Line 166: unsigned int
and this `size_t` too? Done
https://review.coreboot.org/c/flashrom/+/65844/comment/55295c1b_30c609b2 PS86, Line 216: int
`const int` ? Done
https://review.coreboot.org/c/flashrom/+/65844/comment/1efdfbb5_7b526c10 PS86, Line 217: int
`const int` ? Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/65844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256 Gerrit-Change-Number: 65844 Gerrit-PatchSet: 87 Gerrit-Owner: Aarya <aarya.chaumal@gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 26 Jan 2023 10:46:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Aarya (Code Review)