Attention is currently required from: Patrick Georgi.
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/68003
to review the following change.
Change subject: test_build.sh: Improve robustness when dealing with empty $CC ......................................................................
test_build.sh: Improve robustness when dealing with empty $CC
Add quotes so that = knows what to compare, otherwise the shell complains:
./test_build.sh: 16: [: =: unexpected operator
Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/68003/1
diff --git a/test_build.sh b/test_build.sh index 6943701..42c647e 100755 --- a/test_build.sh +++ b/test_build.sh @@ -8,7 +8,7 @@ DRKAISER NICREALTEK NICNATSEMI NICINTEL NICINTEL_SPI NICINTEL_EEPROM OGP_SPI \ BUSPIRATE_SPI DEDIPROG SATAMV LINUX_SPI IT8212 CH341A_SPI"
-if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then +if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi