Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci ......................................................................
Patch Set 12:
(2 comments)
Patchset:
PS12:
I'm not 100% sure it's a move into the right direction. […]
I've an idea how to implement this. I would do this in a follow up patch.
Makefile:
ifeq ($(HAS_LIBPCI),no) $(call mark_unsupported, $(DEPENDS_ON_LIBPCI)) endif
HAS_LIBPCI := $(call find_dependency, libpci)
ifeq ($(HAS_LIBPCI),no) $(call disable, $(DEPENDS_ON_LIBPCI)) endif
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/987be984_7b93e8a0 PS7, Line 772: # This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually. : # libpci may need raw memory, MSR or PCI port I/O on some platforms. : # Individual drivers might have the same needs as well.
Doesn't this comment stay valid? I guess we should at some point untangle our […]
We should split pci programmers to DEPENDS_ON_IO_PORTS, DEPENDS_ON_RAW_MEM_ACCESS, DEPENDS_ON_X86_MSR