Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Dmitry Zhadinets has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/87174?usp=email )
Change subject: cli: Set maximum log level for log callback
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
I realised this is missing only after merging log level callback! […]
Yeah, It should be merged as soon as possible
RUST binding is misaligned with new API as well. It has own set_log_level.
It will work as far as I can see. But maybe someone else can take a look.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/87174?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I70a02ea1a1d692267fd6d92cdb5273786a913777
Gerrit-Change-Number: 87174
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 04 Apr 2025 14:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org