Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros - flashrom-gerrit

7 Apr 2022


      Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 )
Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
......................................................................
Patch Set 13:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62868/comment/941a01ac_a88bad32 
PS12, Line 163: #define HSFC_FCYCLE(cyc)	((cyc) << HSFC_FCYCLE_OFF)
...
Yes, I agree that HSFC_FCYCLE_MASK(n) and HSFC_FCYCLE(n) both unfold into the same expression: (n << […]
Ack
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80
Gerrit-Change-Number: 62868
Gerrit-PatchSet: 13
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Subrata Banik subi.banik@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 07 Apr 2022 19:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment