Attention is currently required from: Michał Żygowski, Jonathan Zhang, David Hendricks, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57793/comment/4cdee6e3_96a30ceb PS3, Line 10: A new chipset : was added that necessitated adding back a check for an older : chipset. That's not accurate. It was the way that the new check was written that made more checks necessary.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/786867a3_89395d49 PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
here too
This one had a different message.
-
Nico Huber (Code Review)