Attention is currently required from: Hsuan Ting Chen, Kapil Porwal.
Anastasia Klimchuk has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashchips.c: Add reg_bits for W25Q256JW ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: Thanks everyone, for contribution and reviews! I have two pieces of information:
1) I leave this unresolved comment as a note this patch will be submitted after v1.5.0 tag is done. ETA 6th December.
Perhaps you already know, but just in case, we are now preparing a release and only merging bugfixes. See the thread for details: https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/WM4CF...
So this is a special time now. At normal time, merging would be in 3 days, process documented here: https://flashrom.org/dev_guide/development_guide.html#merging-patches
2) We are splitting flashchips.c (this was also explained in the same announcement thread). That work will go as https://review.coreboot.org/c/flashrom/+/83307 , but similarly, only after v1.5.0 tag is done. You will need to move your code from `flashchips.c` into `winbond.c`, all the same lines, just copy-paste from one file to the other. You will be able to do all that on 6th December, and then your patch can go ahead.
In general, I recommend subscribing to our public mailing list if you would like to be on the top of what is happening and all the big plans. Thank you! https://flashrom.org/contact.html#mailing-list-1
-
Anastasia Klimchuk (Code Review)