Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58570 )
Change subject: spi25_statusreg,flashchips: add SR2 read/write support
......................................................................
Patch Set 18:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58570/comment/549e9b15_1d5ea58e
PS18, Line 6711: FEATURE_WRSR_EXT
The datasheet suggests this won't work, AFAICT, and I guess this path
is not tested because the code checks `FEATURE_WRSR2` first? You could
test it by removing the latter.
https://review.coreboot.org/c/flashrom/+/58570/comment/5dbbe1d7_f85a54f2
PS18, Line 6872: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP,
Spurious change?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I34a503b0958e8f2f22a2a993a6ea529eb46b41db
Gerrit-Change-Number: 58570
Gerrit-PatchSet: 18
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 15:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment