Change in flashrom[master]: linux_spi.c: Separate shutdown from failed init cleanup - flashrom-gerrit

18 Apr 2021


      Attention is currently required from: Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52284 )
Change subject: linux_spi.c: Separate shutdown from failed init cleanup
......................................................................
Patch Set 2:
(2 comments)
File linux_spi.c:
https://review.coreboot.org/c/flashrom/+/52284/comment/95698951_d6d0f0a4 
PS2, Line 237: 	if (fd != -1) {
This is always true, AFAICS.
https://review.coreboot.org/c/flashrom/+/52284/comment/d80da4db_b060ccd4 
PS2, Line 241: ret
AFAICS, this is always 1.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c8da2878cd0e85a1e43ba9b4b8e6f3d9f38ae5c
Gerrit-Change-Number: 52284
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sun, 18 Apr 2021 16:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment