Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83180?usp=email )
Change subject: flashchips: Add Support for XMC XM25QU80B ......................................................................
Patch Set 2:
(5 comments)
Patchset:
PS2:
Hi Kan, you uploaded new patchset and seems like all comments are resolved, but you haven't marked t […]
Got it.
Commit Message:
https://review.coreboot.org/c/flashrom/+/83180/comment/7d35598d_bb078cef?usp... : PS1, Line 6: : Add Support for XMC XM25QU80B
Prefix with `flashchips: ` so that it's easier to go through the list of commits. […]
Done
https://review.coreboot.org/c/flashrom/+/83180/comment/774b7c3d_37c9feda?usp... : PS1, Line 11:
For adding chip model support, we add in commit message testing info: which programmer you were usin […]
Done
File include/flashchips.h:
https://review.coreboot.org/c/flashrom/+/83180/comment/4588b0ff_03095d61?usp... : PS1, Line 856: #define XMC_XM25QU80B 0x5014
Let's move the line up, put it on #850, after XMC_XM25QU64C. […]
Done
https://review.coreboot.org/c/flashrom/+/83180/comment/5c0fc149_5a69fd5e?usp... : PS1, Line 856: 0x5014
The ID needs to be aligned with the others (see like other IDs all aligned in a column), so you need […]
Done
-
Ssunk (Code Review)