Attention is currently required from: Paul Menzel, Angel Pons, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56799 )
Change subject: realtek_mst_i2c_spi: don't always fail init
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I got confused at first because even initial version of this file has `int ret = SPI_GENERIC_ERROR;`, so this line has always been here. But then I looked closely, the structure of get_params has changed at some point. Previously ret was assigned `ret = 0` in successful case(s), so it was working. And then at some point `ret = 0` was lost.
Peter thank you for fixing this! I assume you tested on the device? Could you please add TEST info to commit message?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1
Gerrit-Change-Number: 56799
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 04 Aug 2021 21:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment