Attention is currently required from: Nicholas Chin, ZhiYuanNJ.
Anastasia Klimchuk has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email )
Change subject: ch347_spi: Add spi clock frequency selection ......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10: I have a question, which is not for this patch, but more for the future.
Would any of you be interested to write a unit test for this programmer? The sibling ch341a_spi already has a unit test which covers init-probe-shutdown. Unit test is not interacting with any hardware, test is running flashrom code. It reduces the risk of breakages, and unit tests run on CI (Jenkins). When a patch gets Verified+1 it means all unit tests pass. I think the existing test for ch341a_spi will have a lot in common with the ch347_spi test.