Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing ......................................................................
Patch Set 19:
(4 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/a9b7085d_e109fcab PS19, Line 72: unsigned int curreadcnt;
Delete, similar to what you did for curwritecnt before
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/e65bea63_c89d74d8 PS19, Line 91: curreadcnt = min(4, readcnt - j);
Change to `uint32_t unsigned int curreadcnt;`, similar to what you did for `curwritecnt` above
I did this so it would compile, and its just what I did before, just a different name of course: uint32_t curreadcnt = min(4, readcnt - j);
https://review.coreboot.org/c/flashrom/+/72057/comment/caa1639e_84d7ca15 PS19, Line 120: 64 * 1024, /* Maximum data read size in one go (excluding opcode+address). */
This can be `MAX_DATA_READ_UNLIMITED`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/8ae5bbce_5b956fe2 PS19, Line 121: 256, /* Maximum data write size in one go (excluding opcode+address). */
This can be `MAX_DATA_WRITE_UNLIMITED`
Done
-
ChrisEric1 CECL (Code Review)