Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/60272 )
Change subject: ichspi: Remove unneeded line breaks, add useful ones ......................................................................
ichspi: Remove unneeded line breaks, add useful ones
BUG=b:204488958
Change-Id: I7ca2902b7caaa95418b828b068c661afafdcd171 Signed-off-by: Anastasia Klimchuk aklm@chromium.org --- M ichspi.c 1 file changed, 12 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/60272/1
diff --git a/ichspi.c b/ichspi.c index 88ac857..d104ef3 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1717,29 +1717,22 @@ { unsigned int i;
- msg_pdbg("0x00: 0x%04x (SPIS)\n", - mmio_readw(spibar + 0)); - msg_pdbg("0x02: 0x%04x (SPIC)\n", - mmio_readw(spibar + 2)); - msg_pdbg("0x04: 0x%08x (SPIA)\n", - mmio_readl(spibar + 4)); + msg_pdbg("0x00: 0x%04x (SPIS)\n", mmio_readw(spibar + 0)); + msg_pdbg("0x02: 0x%04x (SPIC)\n", mmio_readw(spibar + 2)); + msg_pdbg("0x04: 0x%08x (SPIA)\n", mmio_readl(spibar + 4)); + ichspi_bbar = mmio_readl(spibar + 0x50); - msg_pdbg("0x50: 0x%08x (BBAR)\n", - ichspi_bbar); - msg_pdbg("0x54: 0x%04x (PREOP)\n", - mmio_readw(spibar + 0x54)); - msg_pdbg("0x56: 0x%04x (OPTYPE)\n", - mmio_readw(spibar + 0x56)); - msg_pdbg("0x58: 0x%08x (OPMENU)\n", - mmio_readl(spibar + 0x58)); - msg_pdbg("0x5c: 0x%08x (OPMENU+4)\n", - mmio_readl(spibar + 0x5c)); + + msg_pdbg("0x50: 0x%08x (BBAR)\n", ichspi_bbar); + msg_pdbg("0x54: 0x%04x (PREOP)\n", mmio_readw(spibar + 0x54)); + msg_pdbg("0x56: 0x%04x (OPTYPE)\n", mmio_readw(spibar + 0x56)); + msg_pdbg("0x58: 0x%08x (OPMENU)\n", mmio_readl(spibar + 0x58)); + msg_pdbg("0x5c: 0x%08x (OPMENU+4)\n", mmio_readl(spibar + 0x5c));
for (i = 0; i < 3; i++) { int offs; offs = 0x60 + (i * 4); - msg_pdbg("0x%02x: 0x%08x (PBR%u)\n", offs, - mmio_readl(spibar + offs), i); + msg_pdbg("0x%02x: 0x%08x (PBR%u)\n", offs, mmio_readl(spibar + offs), i); } if (mmio_readw(spibar) & (1 << 15)) { msg_pwarn("WARNING: SPI Configuration Lockdown activated.\n"); @@ -1936,8 +1929,7 @@ case LOCKED: msg_pwarn("At least some flash regions are read protected. You have to use a flash\n" "layout and include only accessible regions. For write operations, you'll\n" - "additionally need the --noverify-all switch. See manpage for more details.\n" - ); + "additionally need the --noverify-all switch. See manpage for more details.\n"); break; }