[S] Change in flashrom[master]: tests: Mock the mode_t variant of open - flashrom-gerrit

8 Nov 2022


      Attention is currently required from: Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69263 )
Change subject: tests: Mock the mode_t variant of open
......................................................................
Patch Set 2:
(1 comment)
File tests/wraps.h:
https://review.coreboot.org/c/flashrom/+/69263/comment/526da48e_4531768f 
PS2, Line 33: int __wrap___open64_2(const char *pathname, int flags, mode_t mode);
Checking glibc I see these are in practice declared as ... varargs contrary to the man page. So I should do that here. Not sure if the calling convention just happened to work where i was testing it or what
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/69263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8c134e6d36a248d0f51985e389085a9e585fb83d
Gerrit-Change-Number: 69263
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Nov 2022 05:14:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment