Attention is currently required from: Felix Singer, Nikolai Artemiev.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64851 )
Change subject: libflashrom.map: Add missing functions from libflashrom.h
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64851/comment/094bc8d5_b16e4484
PS1, Line 7: Add all functions from header
Suggestion: […]
Done
https://review.coreboot.org/c/flashrom/+/64851/comment/4a3fb9b3_fc0e63da
PS1, Line 9: I added all
: functioned declared in the header.
Please use imperative. Suggestion: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic90b3c20780d3a07b00bfca82d23d44c4fa6f22f
Gerrit-Change-Number: 64851
Gerrit-PatchSet: 2
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 04:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment