Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55934 )
Change subject: dediprog: Init-shutdown test for dediprog ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55934/comment/dbd1c76d_0340dd8e PS3, Line 9: This patch adds mocks for libusb functions. To avoid dependency on
Yes, hopefully all __wrap functions will be reused for other programmers, because programmer-specifi […]
I will mark this as resolved, but please tell me if you disagree? My plan is to add one more test which uses libusb mocks (I said one or two, but now I think one more is fine), and then return back to this idea.
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/55934/comment/045b73b6_47ae6973 PS3, Line 140: 2021
Yeah that's the current year. […]
I looked at it once again, decided to improve this magic number situation. Now it's in MOCK_HANDLE macro. The number is still magic, but it's only in one place and also macro name gives some explanation.
-
Anastasia Klimchuk (Code Review)