Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops
......................................................................
Patch Set 3:
(2 comments)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/a73c9bd3_c93694d3
PS1, Line 2315: if (!arg && strcmp(arg, "yes"))
: return 0;
Incorrectly applied "!" to the condition and that happened :) That should be !(arg && !strcmp("yes") […]
Done
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/a79cff8d_a5a1be62
PS2, Line 2330: ec_write_cmd(0xc2, EC_MAX_STATUS_CHECKS);
this disables the panel backlight; WMESet probably doesn't set it because ACPI will take care of tha […]
Removed this backlight disable command
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb
Gerrit-Change-Number: 56023
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 08 Jul 2021 15:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment