Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Neill Corlett has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
Ah, hmmm, I'm not sure but I think there are SMBus controller drivers that could still advertise I2C_FUNC_I2C. Can you please confirm that this is not the case. Or can you tell us what controller is used specifically?
Also, is the chip aware if it is connected over SMBus or I2C, e.g. by a pin strap?
I will research this and get back to you. If necessary, we can remove the SMBus code path from mainline, if that would simplify things. Only very early prototype hardware needs it.
Who is PanVision in this story?
They are a vendor who has provided us with the scaler firmware running on the MST chip.
Also, where do you use these chips, integrated display or something external? If you used SMBus, is it even on the mainboard?
This is the scaler chip for the integrated display on the Google Meet Series One Desk 27. It's attached to I2C on the main x86_64 application CPU.
File mediatek_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/61288/comment/dbcfc9df_5a9edf76 PS1, Line 96: args.data->block
I would use `args.data->block + 1` when targeting an array and […]
Inclined to leave as-is unless there are strong objections.
https://review.coreboot.org/c/flashrom/+/61288/comment/1b0b2ff1_d36d7578 PS1, Line 249: 0x426, 7
Hmmm, I see. […]
My understanding is that this is the usual, expected, line that's supposed to go to WP#. In theory it could be wired up another way.
-
Neill Corlett (Code Review)