Change in flashrom[master]: writeprotect: add WPS bit and always set it to zero - flashrom-gerrit

5 Apr 2022


      Attention is currently required from: Nico Huber, Nikolai Artemiev, Edward O'Callaghan, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60231 )
Change subject: writeprotect: add WPS bit and always set it to zero
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Patchset:
PS9: 
I have meta-question, please help me understand where the new WPS bit is used? This patch is adding it, but it is always zero, so it's not used yet. Commit message saying "proper support requires extension of the API as well as implementation", is this a plan, or is it happening later in the chain? Thanks!
Otherwise, looks good.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/60231
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c26ec65d64a3b6fb1f1a73690bc771415db2744
Gerrit-Change-Number: 60231
Gerrit-PatchSet: 9
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev nartemiev@chromium.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 00:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment