Attention is currently required from: Nico Huber, Thomas Heijligen. Hello Nico Huber, Thomas Heijligen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/64425
to review the following change.
Change subject: flashchips.c: Fix 4BA for S25FL512S ......................................................................
flashchips.c: Fix 4BA for S25FL512S
Supporting 4BA read/write instructions without supporting any features to actually use 4BA mode makes no sense. As per the S25FL512 datasheet, `FEATURE_4BA_ENTER_EAR7` and `FEATURE_4BA_EXT_ADDR` are also supported, so select them through `FEATURE_4BA_EAR7`. As it is not known how this chip definition could actually work, it has been marked as untested.
Change-Id: I08c5a70351d945130183fe01c328dc4d30cfe0ef Signed-off-by: Angel Pons th3fanbus@gmail.com --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/64425/1
diff --git a/flashchips.c b/flashchips.c index dfa717b..3e00a87 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16720,8 +16720,8 @@ .total_size = 65536, /* 512 Mb (=> 64 MB)) */ .page_size = 256, /* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_NATIVE, - .tested = TEST_OK_PREW, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_EAR7, + .tested = TEST_UNTESTED, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =