Change in flashrom[master]: layout: Add -i <region>[:<file>] support - flashrom-gerrit

18 Apr 2021


      Attention is currently required from: Sam McNally, Nicola Corna, Jack Rosenthal, Paul Menzel, Stefan Reinauer, David Hendricks, Daniel Campello, Arthur Heymans, Carl-Daniel Hailfinger.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23021 )
Change subject: layout: Add -i <region>[:<file>] support
......................................................................
Patch Set 33:
(1 comment)
Patchset:
PS27:
...
I meant these lines in cli_classic.c: […]
I know, but it doesn't get there. getopt() already notices the error, e.g.
./flashrom: option '--read' requires an argument
Sorry for nitpicking, it seemed you expect the output to stay the same.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/23021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 33
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Gerrit-Reviewer: Daniel Campello campello@chromium.org
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jack Rosenthal jrosenth@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna nicola@corna.info
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Nicola Corna nicola@corna.info
Gerrit-Attention: Jack Rosenthal jrosenth@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Daniel Campello campello@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Gerrit-Comment-Date: Sun, 18 Apr 2021 18:57:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Daniel Campello campello@chromium.org
Gerrit-MessageType: comment