Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23203 )

Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................

Patch Set 24:

(1 comment)

https://review.coreboot.org/#/c/23203/22/fmap.h
File fmap.h:

https://review.coreboot.org/#/c/23203/22/fmap.h@3
PS22, Line 3: -present
> Nah, I kinda like it actually. It just says explicitly what we
> already assume,

Absolutely not. "present" may be interpreted as the point in time
when sb. reads the file, which may be an arbitrary point in the
future but Copyright does not indefinitely extend into the future
(by current law afaik).
> and prevents issues with people updating copyright
> notices needlessly to match the present year whenever they touch a
> file.

"present" when touching a file, yes. But not when reading/copying/
(sb. else)modifying the file. "present" is just not accurate enough.
You could write `2018-<last edit>` and nobody would be offended, I
guess, but "present" leaves too much room for interpretation.
> In any case our non-lawyer opinions are irrelevant, so no point in
> arguing.

I was not too much arguing about the legal situation. Mostly about
the impression Facebook makes. Big ugly company that needs its
special treatment?

I understand the intention. "present" is just the very very wrong
word.