Attention is currently required from: Edward O'Callaghan. Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54849 )
Change subject: meson/: Add missing config for NI845_SPI drv ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
AFAIK, NI845_SPI is Windows-only. […]
Yes, NI-845x is only available on Windows. I am not a Meson expert, by reading the Meson's website it could ran on Windows.
However: If you check the Makefile getting flashrom compiled with NI-845x support is more complicated than linking to the libni845x library.
Depending on the 32/64 bit installation of the NI library separate linker and include paths needs to be passed to the compiler.
-
Miklós Márton (Code Review)