Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67642 )
Change subject: tests: Add unit test for initialisation with NULL programmer param
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/67642/comment/e10a45c5_8f368de6
PS1, Line 42: ;
`= NULL;` and you can avoid the else branch.
Or even:
char *param_dup = param ? strdup(param) : NULL;
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I409f1c9ac832943e54107f7cf8652d1f46ac67df
Gerrit-Change-Number: 67642
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 14 Sep 2022 09:27:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment