Change in flashrom[master]: flashrom: initialize restore func count in correct place - flashrom-gerrit

4 May 2022


      Attention is currently required from: Nico Huber, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63881 )
Change subject: flashrom: initialize restore func count in correct place
......................................................................
Patch Set 5:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/63881/comment/575aeeff_5aaab134 
PS5, Line 1868: 	flash->address_high_byte = -1;
              : 	flash->in_4ba_mode = false;
...
Why move this away from the other 4BA code?
+1
If unlocking doesn't need these values, I wouldn't move them.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/63881
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4c7df424bd2ae2b5fb2a2ab6b47a3c9ff3233acf
Gerrit-Change-Number: 63881
Gerrit-PatchSet: 5
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Wed, 04 May 2022 13:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment