Change in flashrom[master]: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE,

List overview All Threads
Download

newer

older

Change in flashrom[master]: Add...

Change in flashrom[master]:...

Alan Green (Code Review)

24 Jul 2019 24 Jul '19

4:31 a.m.

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE, ......................................................................

flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE,

The AMD Am29F010 was marked TEST_OK_PRE in chromium repo change SHA d217d1219ccaa43a01cd75475409183bd5714410. There are no other differences in the definition of this chip.

This is the only change from the Chromium repo to be upstreamed for AMD chips.

Signed-off-by: Alan Green avg@google.com Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/34534/1

diff --git a/flashchips.c b/flashchips.c index b859bf6..15c33c1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -156,7 +156,7 @@ .total_size = 128, .page_size = 16 * 1024, .feature_bits = FEATURE_ADDR_2AA | FEATURE_EITHER_RESET, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PRE, .probe = probe_jedec, .probe_timing = TIMING_ZERO, .block_erasers =

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Edward O'Callaghan (Code Review)

24 Jul 24 Jul

5:35 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE, ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Gerrit-Change-Number: 34534 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green avg@google.com Gerrit-Assignee: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 05:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:28 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE, ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/flashrom/+/34534/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/34534/1//COMMIT_MSG@7 PS1, Line 7: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE, Please remove the , at the end.

-- To view, visit https://review.coreboot.org/c/flashrom/+/34534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Gerrit-Change-Number: 34534 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green avg@google.com Gerrit-Assignee: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 10:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

26 Jul 26 Jul

8:44 a.m.

New subject: Change in flashrom[master]: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE

Edward O'Callaghan has uploaded a new patch set (#2) to the change originally created by Alan Green. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE ......................................................................

flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE

The AMD Am29F010 was marked TEST_OK_PRE in chromium repo change SHA d217d1219ccaa43a01cd75475409183bd5714410. There are no other differences in the definition of this chip.

This is the only change from the Chromium repo to be upstreamed for AMD chips.

Signed-off-by: Alan Green avg@google.com Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/34534/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/34534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Gerrit-Change-Number: 34534 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green avg@google.com Gerrit-Assignee: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

3 Aug 3 Aug

2:47 p.m.

New subject: Change in flashrom[master]: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE ......................................................................

Patch Set 2: Verified+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/34534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Gerrit-Change-Number: 34534 Gerrit-PatchSet: 2 Gerrit-Owner: Alan Green avg@google.com Gerrit-Assignee: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 03 Aug 2019 14:47:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

2:47 p.m.

New subject: Change in flashrom[master]: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34534 )

Change subject: flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE ......................................................................

flashchips.c: Mark AMD Am29F010A/B as TEST_OK_PRE

The AMD Am29F010 was marked TEST_OK_PRE in chromium repo change SHA d217d1219ccaa43a01cd75475409183bd5714410. There are no other differences in the definition of this chip.

This is the only change from the Chromium repo to be upstreamed for AMD chips.

Signed-off-by: Alan Green avg@google.com Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Reviewed-on: https://review.coreboot.org/c/flashrom/+/34534 Tested-by: Nico Huber nico.h@gmx.de Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: Nico Huber: Verified Paul Menzel: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/flashrom/+/34534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7fa10d33b42c09d035c611535a54592083c4eaa0 Gerrit-Change-Number: 34534 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Assignee: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1968

days inactive

1978

days old

flashrom-gerrit@flashrom.org

5 comments

4 participants

tags (0)

participants (4)

Alan Green (Code Review)
Edward O'Callaghan (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)