Attention is currently required from: Angel Pons.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54276 )
Change subject: Add Gemini Lake support
......................................................................
Patch Set 3:
(1 comment)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/54276/comment/353961ca_db68850f
PS3, Line 2087: 0x31e8
As far as I can tell, LPC and eSPI are mutually exclusive but have different device IDs on Gemini Lake (0x31e8 for LPC, 0x3197 for eSPI), so I think we'll need to match 0x3197 as well.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib5dcdf204166f44a8531c19b5f363b851d2ccd77
Gerrit-Change-Number: 54276
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 17 May 2021 01:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment