[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate - flashrom-gerrit

9 Sep 2022


      Attention is currently required from: Felix Singer, Edward O'Callaghan, Arthur Heymans, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 )
Change subject: tree/: Convert flashchip probe func ptr to enumerate
......................................................................
Patch Set 8:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66781/comment/0c8242f8_fa4f9a6d 
PS8, Line 781: 		probe_func_t *probe_func = lookup_probe_func_ptr(flash->chip);
Why do you look up the function pointer twice?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I00aaab9c83f305cd47e78c36d9c2867f2b73c396
Gerrit-Change-Number: 66781
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Fri, 09 Sep 2022 14:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment