Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62845 )
Change subject: tests: Add padding to pci_dev struct for ASAN ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Oh that's a very good point, and I should have thought about it myself! Especially because this is not the first time, we had the same situation and the same two options for libusb symbols in tests. We had a discussion at that time, and decided to go with option #1, which is in this case
we make libpci a dependency for the tests, then we can include
<pci/pci.h> in the test code.
I think we can reuse the same decision? And that will also make tests consistent.
Which means, specifically: 1) include pci/pci.h in test code 2) remove struct pci_dev from our tests/io_mock.h 3) declare in meson.build that libpci is a dependency for tests (I am not sure how to do this one :)
One thing, Daniel you mentioned "unblock the execution of the tests" but does this patch actually block anything? I understand CB:62844 blocks tests (and it's ready and has no comments). But this one, I don't think so?