Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Hello Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/55999
to review the following change.
Change subject: layout: Turn overlap debug message into warning ......................................................................
layout: Turn overlap debug message into warning
Let's assume this function is only called when overlapping, included regions are fatal.
Change-Id: Ie969e0538d302ccd58d3fec3921265ed3621eaa5 Signed-off-by: Nico Huber nico.huber@secunet.com --- M layout.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/55999/1
diff --git a/layout.c b/layout.c index 36aa247..534deba 100644 --- a/layout.c +++ b/layout.c @@ -266,8 +266,8 @@ if (lhs->end < rhs->start) continue;
- msg_gdbg("Regions %s [0x%08x-0x%08x] and %s [0x%08x-0x%08x] overlap\n", - lhs->name, lhs->start, lhs->end, rhs->name, rhs->start, rhs->end); + msg_gwarn("Regions %s [0x%08x-0x%08x] and %s [0x%08x-0x%08x] overlap\n", + lhs->name, lhs->start, lhs->end, rhs->name, rhs->start, rhs->end); overlap_detected = 1; } }