[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm - flashrom-gerrit

17 Sep 2022


      Attention is currently required from: Simon Buhrow, Nico Huber, Paul Menzel, Aarya.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 54:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/75ada731_6abff9c7 
PS54, Line 1244: 		assert(!ret);
This assert get triggered by the unit tests.
You can run them locally by comiling with meson
`meson build_dir -Dprogrammer=all -Dtests=enabled` -- configure the build
`ninja -C build_dir` -- compile everything
`ninja -C build_dir test` -- run the tests
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 54
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Sat, 17 Sep 2022 08:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment