Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58617 )
Change subject: Makefile: compiler target: separate fixed text and value by a colon ......................................................................
Makefile: compiler target: separate fixed text and value by a colon
Continue to use the "key: value" format like for the C compiler. Use only shell code for TARGET_OS comparison.
Change-Id: I69959c20aa2e43ed67b3057c37e964a34cdab136 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/58617 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 6 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/Makefile b/Makefile index 1c3181a..e84248a 100644 --- a/Makefile +++ b/Makefile @@ -893,17 +893,15 @@ @if [ $(CC_WORKING) = yes ]; \ then $(CC) --version 2>/dev/null | head -1; \ else echo no; echo Aborting.; exit 1; fi - @echo Target arch is $(ARCH) + @echo "Target arch: $(ARCH)" @if [ $(ARCH) = unknown ]; then echo Aborting.; exit 1; fi - @echo Target OS is $(TARGET_OS) + @echo "Target OS: $(TARGET_OS)" @if [ $(TARGET_OS) = unknown ]; then echo Aborting.; exit 1; fi - @echo Target endian is $(ENDIAN) + @if [ $(TARGET_OS) = libpayload ] && ! $(CC) --version 2>&1 | grep -q coreboot; then \ + echo " Warning: It seems you are not using coreboot's reference compiler."; \ + echo " This might work but usually does not, please beware."; fi + @echo "Target endian: $(ENDIAN)" @if [ $(ENDIAN) = unknown ]; then echo Aborting.; exit 1; fi -ifeq ($(TARGET_OS), libpayload) - @$(CC) --version 2>&1 | grep -q coreboot || \ - ( echo "Warning: It seems you are not using coreboot's reference compiler."; \ - echo "This might work but usually does not, please beware." ) -endif
hwlibs: compiler @printf "" > .libdeps
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.