Attention is currently required from: Thomas Heijligen, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel ......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/3254e3d1_f8b535ad PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
Uff, so on x86 platform which have an mtd driver the original internal programmer is broken when CONFIG_LINUX_MTD is compiled in?
No, not broken. It would just prefer a useable MTD interface (i.e. a kernel driver) over flashrom's own drivers.
mark_unsupported sets the CONFIG option with an override to no and prevents the build at the end of the config target.
No, it does either one of these. If a CONFIG option is explicitly set to yes, e.g. on the command line, it would fail with the unsupported message. But if it's not explicitly set to `yes`, it's set to `no`. (it's an if/else, easy to miss the comma that starts the else :-/)
-
Nico Huber (Code Review)