Change in flashrom[master]: Enable dynamic memory allocation checks for cmocka unit tests

[Nico Huber (Code Review)]

Attention is currently required from: David Hendricks, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51243 )

Change subject: Enable dynamic memory allocation checks for cmocka unit tests
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

File meson.build:

https://review.coreboot.org/c/flashrom/+/51243/comment/27bad3fb_f29ac524 
PS6, Line 477: -include
> I tried space after -include and it does not work: […]
> Ah, sorry. I'm still very used to the comfort and pain of having
> everything in a shell command line.

I suppose every string is always passed as one argument, so one
would never have to do any (shell) quoting. Then the separated
alternative would be something like:

     '-include', 'stdlib.h',
     '-include', 'unittest_env.h',

But I'm not even sure if I'd prefer that. Your call.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c6b6b8dc17aaee28640e3fca3d1fc9f7feabf5f
Gerrit-Change-Number: 51243
Gerrit-PatchSet: 7
Gerrit-Owner: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Daniel Kurtz <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Daniel Kurtz <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Thomas Heijligen <[e-mail]>
Gerrit-CC: Victor Ding <[e-mail]>
Gerrit-Attention: David Hendricks <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <[e-mail]>
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Gerrit-MessageType: comment