Attention is currently required from: Felix Singer, Nico Huber, Martin Roth, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 )
Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ......................................................................
Patch Set 1:
(9 comments)
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62768/comment/c28427cb_ce7e20eb PS1, Line 361: .BR "* raiden_debug_spi" " (for SPI flash ROMs attached to a ChromiumOS servo debug board)"
Servo V2 (and maybe V3, which I think is completely obsolete now) uses the FTDI code. […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/d974a0b8_9bf34244 PS1, Line 361: .BR "* raiden_debug_spi" " (for SPI flash ROMs attached to a ChromiumOS servo debug board)"
Servo V2 (and maybe V3, which I think is completely obsolete now) uses the FTDI code. […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/7c648447_9bc335a2 PS1, Line 1137: syntax
Add a comma after syntax
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/9fcda2ec_49b72792 PS1, Line 1137: syntax
Add a comma after syntax
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/50970470_51e21226 PS1, Line 1143: servo serial to use
Clarify whether this is by the serial number of the board or a uart: /dev/tty […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/9706e5d0_30159c3b PS1, Line 1147: syntax.
This sounds wrong here. […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/8b06b089_b3c21eda PS1, Line 1147: syntax.
This sounds wrong here. […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/19834387_a0808d6d PS1, Line 1154: custom_rst=(true,false)
I suggest using this scheme, since it is very common I think. […]
Done
https://review.coreboot.org/c/flashrom/+/62768/comment/b5083811_67a9a393 PS1, Line 1154: custom_rst=(true,false)
I suggest using this scheme, since it is very common I think. […]
Done
-
Edward O'Callaghan (Code Review)