Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/47394 )
Change subject: Disable ENE_LPC and MEC1308 on non-x86 arch ......................................................................
Disable ENE_LPC and MEC1308 on non-x86 arch
Both requires PCI port I/O and hence works only on x86.
TEST=builds on Ubuntu for Raspberry Pi
Signed-off-by: Victor Ding victording@google.com Change-Id: I69e1fbd87819b0b6370f31e9ee4c474500fb3759 --- M Makefile 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/47394/1
diff --git a/Makefile b/Makefile index 225db9d..0498624 100644 --- a/Makefile +++ b/Makefile @@ -544,6 +544,16 @@ else override CONFIG_SATAMV = no endif +ifeq ($(CONFIG_ENE_LPC), yes) +UNSUPPORTED_FEATURES += CONFIG_ENE_LPC=yes +else +override CONFIG_ENE_LPC = no +endif +ifeq ($(CONFIG_MEC1308), yes) +UNSUPPORTED_FEATURES += CONFIG_MEC1308=yes +else +override CONFIG_MEC1308 = no +endif endif
# Disable all drivers needing raw access (memory, PCI, port I/O) on
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47394 )
Change subject: Disable ENE_LPC and MEC1308 on non-x86 arch ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47394 )
Change subject: Disable ENE_LPC and MEC1308 on non-x86 arch ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/47394 )
Change subject: Disable ENE_LPC and MEC1308 on non-x86 arch ......................................................................
Disable ENE_LPC and MEC1308 on non-x86 arch
Both requires PCI port I/O and hence works only on x86.
TEST=builds on Ubuntu for Raspberry Pi
Signed-off-by: Victor Ding victording@google.com Change-Id: I69e1fbd87819b0b6370f31e9ee4c474500fb3759 Reviewed-on: https://review.coreboot.org/c/flashrom/+/47394 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M Makefile 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/Makefile b/Makefile index 225db9d..0498624 100644 --- a/Makefile +++ b/Makefile @@ -544,6 +544,16 @@ else override CONFIG_SATAMV = no endif +ifeq ($(CONFIG_ENE_LPC), yes) +UNSUPPORTED_FEATURES += CONFIG_ENE_LPC=yes +else +override CONFIG_ENE_LPC = no +endif +ifeq ($(CONFIG_MEC1308), yes) +UNSUPPORTED_FEATURES += CONFIG_MEC1308=yes +else +override CONFIG_MEC1308 = no +endif endif
# Disable all drivers needing raw access (memory, PCI, port I/O) on