[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Aarya, Bill XIE.

Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email )

Change subject: erasure_layout: Erase larger block only when all sub-block need erase
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:
> > I will never consider to exchange programming speed with chip lifetime. […]

Thank you for context! This was very educational, I understand now.

It seems like yes, can be an option. Which most of users won't touch and just use default, but still, there can be an option.

However, maybe a build-time option? as is, what we have in `meson_options.txt`
So that you can build flashrom with your preference (chip lifetime), and then run it like that.

We have recently added `delay_minimum_sleep_us` this can be an example.

The option that comes to my mind would be the threshold of how much area covered in small blocks when we decide to switch to large block instead (and you will set it 100). I think it fits naturally into the existing condition...

The biggest challenge is the naming! %) I am making my first attempt as

option name: larger_block_erase_ratio
description: The percent threshold of how much area to erase is covered by smaller-size blocks, at this percent coverage we switch to a larger block to cover the area

default can stay the same as it is now, 50, and then if decided, it can be later changed in a separate 1-line patch.

what do you think?