Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55934 )
Change subject: dediprog: Init-shutdown test for dediprog ......................................................................
Patch Set 2:
(2 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/55934/comment/7a6ab449_5ae300c3 PS2, Line 108: /* Manual voltage setting */ It does more than that. Probably doesn't need a comment.
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/55934/comment/a239c0c4_44634e79 PS2, Line 52: */ You could also declare it above.
struct libusb_device_handle; typedef struct libusb_device_handle libusb_device_handle;
Not more clutter than the comment ^^
-
Nico Huber (Code Review)