Attention is currently required from: Aarya, Nikolai Artemiev, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82496?usp=email )
Change subject: Correct get_flash_region() to use inclusive upper bounds ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2: Thank you for fixing old tech debt !
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/82496/comment/772c9434_a3c6054d?usp... : PS2, Line 1518: region.end - 1 `region.end` like in everywhere else?
https://review.coreboot.org/c/flashrom/+/82496/comment/d494ed4d_802c4ab2?usp... : PS2, Line 1524: region.end - 1 also `region.end` ?
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/82496/comment/d5160f98_f0187702?usp... : PS2, Line 1454: limit Why you are changing this? I understand why region end changes, but why region start?
Is this another bug?