[S] Change in flashrom[master]: programmer.h: Guard against sending spi commands on non-spi mst - flashrom-gerrit

7 Jan 2023


      Attention is currently required from: Sam McNally, Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71269 )
Change subject: programmer.h: Guard against sending spi commands on non-spi mst
......................................................................
Patch Set 2:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71269/comment/3751906d_36a73bbc 
PS1, Line 1937: spi_master_no_4ba_modes
...
Could we skip this entire section on 4ba for non-SPI masters?
I feel like the code needs a bit of work.. Can we just fix the immediate issue first (>16MB flashing is broken on ichspi).
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7cce4f9c032d33c01bf616e27a50b9727a40fe1b
Gerrit-Change-Number: 71269
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 07 Jan 2023 09:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally sammc@google.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment