Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 )
Change subject: meson: add option to disable tests ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63832/comment/e9492ee2_b4986aab PS1, Line 10: Run `meson -Dtests=true` to enable tests. (default) : Run `meson -Dtests=false` to disable tests.
One last test scenario: does it work with no option mentioned in command line? just meson, or just m […]
I've updated the commit message. Now it should be mode clear what happen. When you run `meson build` tests are enabled as before.
File meson.build:
https://review.coreboot.org/c/flashrom/+/63832/comment/b3253822_af04a01a PS1, Line 522: if cmocka_dep.found()
I remember that is an important thing, to check cmocka dep. […]
cmocka is now a required dependency for tests. Therefore the `if cmocka_dep.found()` is no longer needed. There are only two options: tests are enabled and cmocka is required and tests are disabled and cmocka is not required. We could soften this by using a feature option which has a tristate: `auto`, `enabled` and `disabled`.
TODO: Add `not_found_message` to cmocka dependency
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/63832/comment/853b8ee1_1c0ababa PS1, Line 45: and run
I think tests will only be run via `meson test`, so this option only controls whether they're built […]
Done
-
Thomas Heijligen (Code Review)