Attention is currently required from: Felix Singer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Name udev-rules file accordingly ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/8f00046e_17d8f550 PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
They have to read the file first anyway. Not every distro uses the same […]
As upstream systemd/udev uses ordering, I think that is the way to do it.
There is no reason specified, why all distributions already packaging flashrom have to adapt their packaging scripts to use the new name. The commit message does not say, why the new name is better, and I still do not see a reason.
[1]: https://github.com/systemd/systemd/tree/main/rules.d
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/eb92b1c3_c0c12144 PS4, Line 7: accordingly Just saw this now. This is missing something. “accordingly” to what?
-
Paul Menzel (Code Review)