Change in flashrom[master]: Fix -Wunused-parameter issues - flashrom-gerrit

3 Aug 2019


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues
......................................................................
Patch Set 5: Code-Review+1
...
Patch Set 5:
...
I personally think "(void)flash;" looks really ugly
It really does.
Though, I try not to judge it by asthetics but the potential
benefit of the warning. Does anybody recall or imagine bugs
that would be prevented by -Wunused-parameter?
Or maybe hide the ugliness behind a macro...
(please don't shoot me for suggesting that)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Richard Hughes richard@hughsie.com
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 21:43:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment