Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 )
Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ......................................................................
Patch Set 8:
(1 comment)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/56023/comment/ddf9d231_a8cad7a6 PS2, Line 2339: return 0; I see, that's indeed a very good reason to implement it differently. Well, I had already had asked that above btw :P
Sorry, I thought one had to apply a command (-r -w -v), too, but that's not the case. For me this is fine. What do others say? ... I too, would either add this functionality to intelmetool or bail out after setting the unlock bit (handle it like a independent command just like -r, -w, -v).
One argument for having it in flashrom is that unlocking IFD/ME is very related to flashing.
Another argument for having that functionality in flashrom is that users don't need to install another independent tool, that might not yet be available on their distro, while flashrom already is available broadly.
TL;DR what about adding `--unlock-me` as operation, so the command would be `flashrom -p internal --unlock-me` or `... -u`.
-
Michael Niewöhner (Code Review)